Skip to content

Conversation

@peterellisjones
Copy link

@peterellisjones peterellisjones commented Sep 26, 2022

Are you submitting this PR against the develop branch?

👍

What is this change about?

Currently the Dynamic ASG test works the following way:

  • Make a request from a test app to cloud-controller-ng.service.cf.internal:9024/v2/info
  • Verify the request was blocked
  • Add a security group rule allows the app to make TCP connections to port 9024 in IP range 10.0.0.0/8
  • Verify the request is now allowed
  • Remove the security group
  • Verify the request is blocked again

This test requires/assumes that:

  • cloud-controller-ng.service.cf.internal:9024 is currently blocked by the platform-wide running ASGs
  • The Cloud Controller is deployed to an IP in the range 10.0.0.0/8
  • cloud-controller-ng.service.cf.internal resolves to a Cloud Controller VM IP

This PR adds an optional configuration parameter dynamic_asg_test_config which can be used to change the test to work in environments where the above assumptions don't hold. By default the test will use the current logic, but dynamic_asg_test_config can be used to override the following parameters:

  • endpoint_host: Hostname or IP for test endpoint to allow/block
  • endpoint_port: Port for test endpoint to allow/block
  • endpoint_path: HTTP Path for test endpoint to allow/block
  • endpoint_allow_ip_range: IP range used for allowing and blocking access to the test endpoint. This can be a single IP address, a range like 192.0.2.0-192.0.2.50, or a CIDR block like 10.0.0.0/8.

What version of cf-deployment have you run this cf-acceptance-test change against?

21.9

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

0

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Tag your pair, your PM, and/or team!

This work is done on behalf of Fidelity International

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 26, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: peterellisjones / name: Peter Jones (c3f61ca)

@peterellisjones peterellisjones force-pushed the configurable-dynamic-asg-test-endpoint branch from f0283ba to c3f61ca Compare September 26, 2022 12:53
@peterellisjones peterellisjones marked this pull request as ready for review September 28, 2022 14:59
@ctlong
Copy link
Member

ctlong commented Feb 27, 2025

Closing this PR due to inactivity. Please feel free to reopen it if you're still interested 😄

@ctlong ctlong closed this Feb 27, 2025
@github-project-automation github-project-automation bot moved this from Pending Review to Done in App Runtime Deployments Working Group Feb 27, 2025
@peterellisjones
Copy link
Author

@ctlong this is still a relevant and useful change -- it's just been waiting for someone to review and merge it

@ctlong ctlong reopened this Mar 1, 2025
@github-project-automation github-project-automation bot moved this from Done to Waiting on feedback in App Runtime Deployments Working Group Mar 1, 2025
@ctlong
Copy link
Member

ctlong commented Mar 1, 2025

From a quick glance the changes LGTM!

@peterellisjones can you please rebase this PR and I'll perform a more thorough review?

@ctlong ctlong assigned ctlong and peterellisjones and unassigned ctlong Mar 1, 2025
@ctlong ctlong moved this from Waiting on feedback to Waiting for Changes in App Runtime Deployments Working Group Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Waiting for Changes

Development

Successfully merging this pull request may close these issues.

2 participants