Skip to content

Add region to the s3 compatible integration tests #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-hassanin merged 2 commits into from
Jan 27, 2026
+2 −11
Merged

Add region to the s3 compatible integration tests #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8583ac
Add region to the s3 compatible integration tests
Ivaylogi98 Jan 26, 2026
78ff274
Update docs
Ivaylogi98 Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,7 @@ Given a JSON config file (`config.json`)...
"multipart_upload": "<bool> (optional - default: true)",
}
```
> Note: Provider specific configuration (automatically set to false by parsing the provided 'host') :
> 1. **multipart_upload** - not supported by Google
> 1. **request_checksum_calculation_enabled** - not supported by Google and AliCloud
> 2. **uploader_checksum_calculation_enabled** - not supported by AliCloud
> Note: **multipart_upload** is not supported by Google - it's automatically set to false by parsing the provided 'host'
``` bash
# Usage
Expand Down
8 changes: 1 addition & 7 deletions integration/s3_compatible_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,6 @@ var _ = Describe("Testing in any non-AWS, S3 compatible storage service", func()
})

configurations := []TableEntry{
Entry("with the minimal configuration", &config.S3Cli{
AccessKeyID: accessKeyID,
SecretAccessKey: secretAccessKey,
BucketName: bucketName,
Host: s3Host,
MultipartUpload: true,
}),
Entry("with region specified", &config.S3Cli{
AccessKeyID: accessKeyID,
SecretAccessKey: secretAccessKey,
Expand All @@ -50,6 +43,7 @@ var _ = Describe("Testing in any non-AWS, S3 compatible storage service", func()
SecretAccessKey: secretAccessKey,
BucketName: bucketName,
Host: s3Host,
Region: "invalid-region",
UseSSL: false,
MultipartUpload: true,
}),
Expand Down