enable omission of config.json / read config from env; add debug option #62
+50
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schnoddelbotz
force-pushed
the
env-config
branch
from
961b518 to
07a0422
Compare
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Author
|
Doh. I just spotted #28 (comment) ... Feel free to just close this PR accordingly. Might be a good idea to mention that policy in the README though. |
aramprice
requested review from
a team,
Sascha-Stoj and
gururajsh
and removed request for
a team
aramprice
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
Member
|
Thanks for the contribution! Just wanted to let you know we're actually moving this functionality to https://github.com/cloudfoundry/storage-cli. Would you mind opening the PR there instead? We'll be deprecating this repository soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For usage in CI pipelines, configuration via env instead of json file seemed like a good idea to me.
Tried to make that happen, minimally invasive.
Also added a debug flag - currently only available by setting
S3_DEBUGto a non-zero string.Will happily enhance README with usage details in case the overall idea seems sound.