Skip to content

Conversation

@ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Apr 29, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Enhance recursive action checks with project ID tracking

Known issue

@ImMin5 ImMin5 added the enhancement New feature or request label Apr 29, 2025
@ImMin5 ImMin5 requested a review from Copilot April 29, 2025 01:27
@ImMin5 ImMin5 self-assigned this Apr 29, 2025
@github-actions
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 1 commits:

  • cd9b746: feat: enhance recursive action checks with project ID tracking

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 1 commits:

  • cd9b746: feat: enhance recursive action checks with project ID tracking

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances recursive action checks by tracking project IDs across recursive calls to prevent unintended loops.

  • Introduces a project_ids list to track project IDs in both the create and update flows.
  • Updates the recursive action checking logic to use a deepcopy of project_ids (renamed locally as visited_projects) for recursion prevention.
Comments suppressed due to low confidence (1)

src/spaceone/monitoring/service/event_rule_service.py:455

  • [nitpick] The variable name 'visited_projects' may be ambiguous. Consider renaming it to 'visited_project_ids' for clarity and consistency with 'project_ids'.
visited_projects = deepcopy(project_ids)

@github-actions
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 2 commits:

  • cd9b746: feat: enhance recursive action checks with project ID tracking
  • 7f49d4e: feat: modify var name for clarity

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 2 commits:

  • cd9b746: feat: enhance recursive action checks with project ID tracking
  • 7f49d4e: feat: modify var name for clarity

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@ImMin5 ImMin5 merged commit ddbefb4 into cloudforet-io:master Apr 29, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fail/signedoff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant