-
Notifications
You must be signed in to change notification settings - Fork 10
Enhance recursive action checks with project ID tracking #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
1 similar comment
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances recursive action checks by tracking project IDs across recursive calls to prevent unintended loops.
- Introduces a project_ids list to track project IDs in both the create and update flows.
- Updates the recursive action checking logic to use a deepcopy of project_ids (renamed locally as visited_projects) for recursion prevention.
Comments suppressed due to low confidence (1)
src/spaceone/monitoring/service/event_rule_service.py:455
- [nitpick] The variable name 'visited_projects' may be ambiguous. Consider renaming it to 'visited_project_ids' for clarity and consistency with 'project_ids'.
visited_projects = deepcopy(project_ids)
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
1 similar comment
|
✅ Why it is requiredThe Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO. Contributors sign-off that they adhere to these requirements by adding a Git even has a |
Category
Description
Known issue