Skip to content

Conversation

@ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Apr 25, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • add recursive action checks and pagination limit for event rules

Known issue

@ImMin5 ImMin5 added the bug Something isn't working label Apr 25, 2025
@ImMin5 ImMin5 requested a review from Copilot April 25, 2025 10:22
@ImMin5 ImMin5 self-assigned this Apr 25, 2025
@ImMin5 ImMin5 merged commit f0cf24b into cloudforet-io:master Apr 25, 2025
1 of 3 checks passed
@github-actions
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 2 commits:

  • 621e120: feat: add recursive action checks and pagination limit for event rules
  • 14d6832: chore: remove debug code

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link

⚠️ @ImMin5 the signed-off-by was not found in the following 2 commits:

  • 621e120: feat: add recursive action checks and pagination limit for event rules
  • 14d6832: chore: remove debug code

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in event rule processing by adding recursive validations for action rules and limits alert query pagination while cleaning up leftover debug statements.

  • Added recursive action validation checks in event_rule_service.py
  • Applied a pagination limit of 1000 in alert_service.py
  • Removed a debugging print statement in alert_manager.py and refactored a minor formatting change in event_rule_manager.py

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/spaceone/monitoring/service/event_rule_service.py Added recursive action checks for event rule validations
src/spaceone/monitoring/service/alert_service.py Applied a pagination limit decorator and introduced a new import
src/spaceone/monitoring/manager/event_rule_manager.py Introduced a new filter_event_rules method with minor formatting adjustments
src/spaceone/monitoring/manager/alert_manager.py Removed a debug print statement
Comments suppressed due to low confidence (2)

src/spaceone/monitoring/manager/alert_manager.py:28

  • Remove the debugging print statement to avoid unintended logging in production.
print(params)

src/spaceone/monitoring/service/alert_service.py:4

  • The import 'page_size_length' is not used in the current diff. Consider removing it to reduce unnecessary dependencies.
from pandas.io.sas.sas_constants import page_size_length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working fail/signedoff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant