Skip to content

Conversation

@lhhyung
Copy link
Member

@lhhyung lhhyung commented Jul 30, 2025

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

Update role-based query data handling for workspace owners

Known issue

@lhhyung lhhyung requested a review from Copilot July 30, 2025 04:00
@lhhyung lhhyung self-assigned this Jul 30, 2025
@lhhyung lhhyung added enhancement New feature or request pass/signedoff labels Jul 30, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes role-based query data handling by adding specific workspace owner logic to the data table manager. Previously, only workspace members had special handling, but workspace owners now get their workspace ID added to query variables.

  • Added conditional logic for WORKSPACE_OWNER role type
  • Extracted workspace ID from transaction metadata for workspace owners
  • Maintained existing logic for workspace members


if role_type == "WORKSPACE_MEMBER":
if role_type == "WORKSPACE_OWNER":
workspace_id = self.transaction.get_meta("authorization.workspace_id")
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code doesn't handle the case where workspace_id might be None or empty. Consider adding validation to ensure workspace_id is valid before adding it to query_data.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

⚠️ @lhhyung the signed-off-by was not found in the following 1 commits:

  • 4b3366d: feat: Update role-based query data handling for workspace owners

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

1 similar comment
@github-actions
Copy link

⚠️ @lhhyung the signed-off-by was not found in the following 1 commits:

  • 4b3366d: feat: Update role-based query data handling for workspace owners

✅ Why it is required

The Developer Certificate of Origin (DCO) is a lightweight way for contributors to certify that they wrote or otherwise have the right to submit the code they are contributing to the project. Here is the full text of the DCO.

Contributors sign-off that they adhere to these requirements by adding a Signed-off-by line to commit messages.

This is my commit message

Signed-off-by: Random Developer <randomdeveloper@example.com>

Git even has a -s command line option to append this automatically to your commit message:

$ git commit -s -m 'This is my commit message'

@lhhyung lhhyung merged commit 6e97cda into cloudforet-io:master Jul 30, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant