Skip to content

Add validation logic #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stat-kwon merged 1 commit into from
Feb 25, 2025
Merged

Add validation logic #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions src/spaceone/dashboard/manager/data_table_manager/data_source_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,16 +415,17 @@ def _make_query(
copied_vars = copy.deepcopy(vars) or {}
self.filter = self.filter or []

for key, value in vars.items():
if key in ["workspace_id", "project_id", "service_account_id"]:
self.process_key(key, value)
del copied_vars[key]
elif key == "region_code":
label_key = (
"labels.Region" if self.source_type != "COST" else "region_code"
)
self.process_key(key, value, label_key)
del copied_vars[key]
if copied_vars:
for key, value in vars.items():
if key in ["workspace_id", "project_id", "service_account_id"]:
self.process_key(key, value)
del copied_vars[key]
elif key == "region_code":
label_key = (
"labels.Region" if self.source_type != "COST" else "region_code"
)
self.process_key(key, value, label_key)
del copied_vars[key]

if copied_vars:
dashboard_info = self.public_dashboard_mgr.get_public_dashboard(
Expand Down
Loading