Skip to content

Conversation

@jinyoungmoonDEV
Copy link
Contributor

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • fix cost report date calculate logic

Signed-off-by: jinyoungmoonDEV <moonjinyoung.dev@gmail.com>
@jinyoungmoonDEV jinyoungmoonDEV requested a review from Copilot June 12, 2025 08:49
@jinyoungmoonDEV jinyoungmoonDEV merged commit 9fa630b into cloudforet-io:master Jun 12, 2025
3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the cost report date calculation logic by updating the adjustment period, retry calculation, and report flag conditions.

  • Updates the adjustment and retry calculations to reflect new logic for determining retry days.
  • Reorganizes the conditional blocks for setting report flags and dates.
Comments suppressed due to low confidence (3)

src/spaceone/cost_analysis/service/cost_report_serivce.py:0

  • The file name 'cost_report_serivce.py' appears to have a typo; consider renaming it to 'cost_report_service.py' for clarity and consistency.
File name appears as cost_report_serivce.py

src/spaceone/cost_analysis/service/cost_report_serivce.py:502

  • Changing total_retry_days to use the maximum of adjustment_period and retry_days instead of their sum significantly alters the retry calculation logic; please confirm that this revised logic is intended.
total_retry_days = max(adjustment_period, retry_days)

src/spaceone/cost_analysis/service/cost_report_serivce.py:558

  • Setting self.is_done_report to True unconditionally within the current_date >= done_date branch may override the check performed by _check_done_cost_report_exist; please verify if this behavior is as intended.
self.is_done_report = True

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant