Skip to content

fix: use correct R2 Catalog error code in pipelines setup #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
garvit-gupta wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use correct R2 Catalog error code in pipelines setup #12694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rude-ends-battle.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler": patch
---

Fix `wrangler pipelines setup` failing for Data Catalog sinks on new buckets by using the correct R2 Catalog API error code (`40401`).
2 changes: 1 addition & 1 deletion packages/wrangler/src/__tests__/pipelines-setup.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ describe("wrangler pipelines setup", () => {
if (!exists) {
return HttpResponse.json(
createFetchResult(null, false, [
{ code: 10006, message: "catalog not found" },
{ code: 40401, message: "Warehouse not found" },
]),
{ status: 404 }
);
Expand Down
2 changes: 1 addition & 1 deletion packages/wrangler/src/pipelines/cli/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ async function ensureCatalogEnabled(
const catalog = await getR2Catalog(config, accountId, bucketName);
catalogEnabled = catalog.status === "active";
} catch (err) {
if (err instanceof APIError && err.code === 10006) {
if (err instanceof APIError && err.code === 40401) {
// Catalog not enabled yet
} else {
throw err;
Expand Down
Loading