Skip to content

Log periodically when deleteAll is called with an alarm still set #6056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a-robinson merged 1 commit into from
Feb 11, 2026
+9 −0
Merged

Log periodically when deleteAll is called with an alarm still set #6056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/workerd/io/actor-cache.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2056,6 +2056,12 @@ ActorCache::DeleteAllResults ActorCache::deleteAll(WriteOptions options, SpanPar
evictOrOomIfNeeded(lock);
}

KJ_IF_SOME(t, currentAlarmTime.tryGet<KnownAlarmTime>()) {
if (t.time != kj::none) {
LOG_WARNING_PERIODICALLY("NOSENTRY deleteAll() called on ActorCache with an alarm still set");
}
}

return DeleteAllResults{.backpressure = getBackpressure(), .count = kj::mv(result)};
}

Expand Down
3 changes: 3 additions & 0 deletions src/workerd/io/actor-sqlite.c++
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,6 +767,9 @@ ActorCacheInterface::DeleteAllResults ActorSqlite::deleteAll(
// the metadata table, to try to match the behavior of ActorCache, which preserves the set alarm
// when running deleteAll().
auto localAlarmState = metadata.getAlarm();
if (localAlarmState != kj::none) {
LOG_WARNING_PERIODICALLY("NOSENTRY deleteAll() called on ActorSqlite with an alarm still set");
}

// deleteAll() cannot be part of a transaction because it deletes the database altogether. So,
// we have to close our transactions or fail.
Expand Down
Loading