Condemn the isolate when there is a Python fatal error #6054
Conversation
hoodmane
force-pushed
the
hoodmane/codemn-pyodide-fatals
branch
from
f71e357 to
543a048
Compare
ryanking13
left a comment
ryanking13
left a comment
There was a problem hiding this comment.
Is there some way to unit test this behavior?
|
It's tested in the other repo. Though maybe I can use sub requests to test it here -- it's a bit tricky to use |
1 similar comment
|
It's tested in the other repo. Though maybe I can use sub requests to test it here -- it's a bit tricky to use |
| kj::Exception error(kj::Exception::Type::FAILED, __FILE__, __LINE__, kj::mv(description)); | ||
|
|
||
| // Condemn the isolate so future requests get a fresh one | ||
| Worker::Isolate::from(js).getLimitEnforcer().condemn(); |
There was a problem hiding this comment.
As I've mentioned in upstream PR, I think we want a custom method for this.
danlapid
left a comment
danlapid
left a comment
There was a problem hiding this comment.
Can we re-discuss this please? I don't like this approach.
We need to think of a good approach that we can actually give users.
Ideally one that doesn't find a way to use internal APIs.
We need to make sure what we do works and is available for rust users as well
@guybedford
4 participants
No description provided.