Skip to content

Conversation

@FlorentCollin
Copy link
Member

We were trying to call addAggregatedD1MetaToSpan before checking if any of the results are errors in a .exec call. When an error is returned the meta property is not set.

This commit is now checking the errors first and then call the addAggregatedD1MetaToSpan if there is no error.

@FlorentCollin FlorentCollin requested review from a team as code owners February 6, 2026 14:39
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 6, 2026

Merging this PR will not alter performance

✅ 70 untouched benchmarks
⏩ 129 skipped benchmarks1


Comparing fcollin/CFSQL-1473-fix-db-exec-type-error (297101f) with main (02f8f80)

Open in CodSpeed

Footnotes

  1. 129 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1473-fix-db-exec-type-error branch 3 times, most recently from d9b21f5 to 47e7695 Compare February 6, 2026 17:23
@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1473-fix-db-exec-type-error branch 3 times, most recently from e4a53c4 to cba88fe Compare February 10, 2026 09:20
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1473-fix-db-exec-type-error branch from cba88fe to a4fe5bc Compare February 10, 2026 10:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.36%. Comparing base (02f8f80) to head (297101f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6029      +/-   ##
==========================================
+ Coverage   70.34%   70.36%   +0.01%     
==========================================
  Files         408      408              
  Lines      108646   108646              
  Branches    17991    17991              
==========================================
+ Hits        76431    76444      +13     
+ Misses      21412    21402      -10     
+ Partials    10803    10800       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1473-fix-db-exec-type-error branch from a4fe5bc to 8be4e22 Compare February 10, 2026 11:25
We were trying to call `addAggregatedD1MetaToSpan` before checking if
any of the results are errors in a `.exec` call. When an error is returned the meta
property is not set.

This commit is now checking the errors first and then call the
`addAggregatedD1MetaToSpan` if there is no error.
@FlorentCollin FlorentCollin force-pushed the fcollin/CFSQL-1473-fix-db-exec-type-error branch from 8be4e22 to 9f88c74 Compare February 10, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants