-
Notifications
You must be signed in to change notification settings - Fork 529
CFSQL-1473: fix D1 exec throwing TypeError on invalid SQL queries #6029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
d9b21f5 to
47e7695
Compare
e4a53c4 to
cba88fe
Compare
|
The generated output of |
cba88fe to
a4fe5bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6029 +/- ##
==========================================
+ Coverage 70.34% 70.36% +0.01%
==========================================
Files 408 408
Lines 108646 108646
Branches 17991 17991
==========================================
+ Hits 76431 76444 +13
+ Misses 21412 21402 -10
+ Partials 10803 10800 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4fe5bc to
8be4e22
Compare
We were trying to call `addAggregatedD1MetaToSpan` before checking if any of the results are errors in a `.exec` call. When an error is returned the meta property is not set. This commit is now checking the errors first and then call the `addAggregatedD1MetaToSpan` if there is no error.
8be4e22 to
9f88c74
Compare
We were trying to call
addAggregatedD1MetaToSpanbefore checking if any of the results are errors in a.execcall. When an error is returned the meta property is not set.This commit is now checking the errors first and then call the
addAggregatedD1MetaToSpanif there is no error.