fix(node): make readline Interface and Readline classes no-op stubs #6016
+147
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the readline Interface class and the readline/promises Interface and Readline classes to be no-op stubs instead of throwing errors. This matches the behavior of unenv's readline implementation, which allows code that depends on readline to work without crashing even though the functionality is not fully implemented. Methods now return sensible defaults (empty strings, zero values, etc.) instead of throwing ERR_METHOD_NOT_IMPLEMENTED errors. Fixes compatibility with cloudflare/workers-sdk#11734
|
The generated output of |
anonrig
approved these changes
Feb 4, 2026
| throw new ERR_METHOD_NOT_IMPLEMENTED('Interface.question'); | ||
| // If callback is the second argument (no options) | ||
| if (typeof _options === 'function') { | ||
| (_options as (answer: string) => void)(''); |
Member
There was a problem hiding this comment.
can you remove unknown type in function declaration and use the union of two types to avoid this?
| [Symbol.asyncIterator](): NodeJS.AsyncIterator<string, undefined, any> { | ||
| throw new ERR_METHOD_NOT_IMPLEMENTED('Interface[Symbol.asyncIterator]'); | ||
| async *[Symbol.asyncIterator](): NodeJS.AsyncIterator<string> { | ||
| yield ''; |
Member
There was a problem hiding this comment.
Can we add a comment to why we are returning this?
| [Symbol.asyncIterator](): NodeJS.AsyncIterator<string, undefined, any> { | ||
| throw new ERR_METHOD_NOT_IMPLEMENTED('Interface[Symbol.asyncIterator]'); | ||
| async *[Symbol.asyncIterator](): NodeJS.AsyncIterator<string> { | ||
| yield ''; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interfaceclass and the readline/promisesInterfaceandReadlineclasses to be no-op stubs instead of throwing errorsERR_METHOD_NOT_IMPLEMENTEDerrorsFixes compatibility with cloudflare/workers-sdk#11734