-
Notifications
You must be signed in to change notification settings - Fork 529
add a compat enabled date for fetchIterableTypeSupport #6006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The generated output of |
3928134 to
08e9953
Compare
CodSpeed Performance ReportMerging this PR will degrade performance by 18.38%Comparing Summary
Performance Changes
Footnotes
|
|
Thanks for the reviews! |
Make
fetchIterableTypeSupportenabled by default from 2026-02-19.Note that
fetchIterableTypeSupportOverrideAdjustmentwill also be enabled by default from that date because it hasworkerd/src/workerd/io/compatibility-date.capnp
Line 1262 in a89ad60
Some more details about this PR:
When we tried to enable the native
node:processv2, we ran into issue because it caused astro to detect theworkerdruntime as if it was Node and triggering a known issue in the code path it would then take.Our plan is to make sure both
fetchIterableTypeSupportandfetchIterableTypeSupportOverrideAdjustmentare enabled before enablingnode:process.This is detailed in this workers-sdk issue. Please read it, ask questions, and give feedback.
/cc @danlapid @jasnell @guybedford