Skip to content

Fix deprecation warnings with V8 14.4 #5872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fhanau wants to merge 1 commit into from
Closed

Fix deprecation warnings with V8 14.4 #5872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/workerd/jsg/resource.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ struct GetterCallback;
liftKj(info, [&]() { \
auto isolate = info.GetIsolate(); \
auto context = isolate->GetCurrentContext(); \
auto obj = info.This(); \
auto obj = info.HolderV2(); \
auto& js = Lock::from(isolate); \
auto& wrapper = TypeWrapper::from(isolate); \
/* V8 no longer supports AccessorSignature, so we must manually verify `this`'s type. */ \
Expand Down Expand Up @@ -682,7 +682,7 @@ struct GetterCallback;
auto isolate = info.GetIsolate(); \
auto context = isolate->GetCurrentContext(); \
auto& js = Lock::from(isolate); \
auto obj = info.This(); \
auto obj = info.HolderV2(); \
auto& wrapper = TypeWrapper::from(isolate); \
/* V8 no longer supports AccessorSignature, so we must manually verify `this`'s type. */ \
if (!isContext && \
Expand Down Expand Up @@ -880,7 +880,7 @@ struct SetterCallback<TypeWrapper, methodName, void (T::*)(Arg), method, isConte
auto isolate = info.GetIsolate();
auto context = isolate->GetCurrentContext();
auto& js = Lock::from(isolate);
auto obj = info.This();
auto obj = info.HolderV2();
auto& wrapper = TypeWrapper::from(isolate);
// V8 no longer supports AccessorSignature, so we must manually verify `this`'s type.
if (!isContext && !wrapper.getTemplate(isolate, static_cast<T*>(nullptr))->HasInstance(obj)) {
Expand All @@ -906,7 +906,7 @@ struct SetterCallback<TypeWrapper, methodName, void (T::*)(Lock&, Arg), method,
liftKj(info, [&]() {
auto isolate = info.GetIsolate();
auto context = isolate->GetCurrentContext();
auto obj = info.This();
auto obj = info.HolderV2();
auto& wrapper = TypeWrapper::from(isolate);
// V8 no longer supports AccessorSignature, so we must manually verify `this`'s type.
if (!isContext && !wrapper.getTemplate(isolate, static_cast<T*>(nullptr))->HasInstance(obj)) {
Expand Down Expand Up @@ -1193,7 +1193,7 @@ struct WildcardPropertyCallbacks<TypeWrapper,
liftKj(info, [&]() -> v8::Local<v8::Value> {
auto isolate = info.GetIsolate();
auto context = isolate->GetCurrentContext();
auto obj = info.This();
auto obj = info.HolderV2();
auto& wrapper = TypeWrapper::from(isolate);
if (!wrapper.getTemplate(isolate, static_cast<T*>(nullptr))->HasInstance(obj)) {
throwTypeError(isolate, kIllegalInvocation);
Expand Down
Loading