Skip to content

Fix query/cost suggestions#1752

Merged
prymitive merged 1 commit intomainfrom
query
Apr 2, 2026
Merged

Fix query/cost suggestions#1752
prymitive merged 1 commit intomainfrom
query

Conversation

@prymitive
Copy link
Copy Markdown
Collaborator

No description provided.

@prymitive prymitive enabled auto-merge April 2, 2026 10:47
Copy link
Copy Markdown

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.79.0-96-g281e23d9
Number of rules parsed 9
Number of rules checked 9
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.57%. Comparing base (8f08caf) to head (281e23d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1752   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         109      109           
  Lines       13277    13280    +3     
=======================================
+ Hits        13220    13223    +3     
  Misses         32       32           
  Partials       25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
                    │   old.txt   │              new.txt               │
                    │   sec/op    │   sec/op     vs base               │
GlobFinder-4          18.64m ± 4%   18.65m ± 5%       ~ (p=0.393 n=10)
GitFinder-4           357.8m ± 1%   360.2m ± 1%  +0.68% (p=0.007 n=10)
CheckRules-4           9.628 ± 1%    9.632 ± 1%       ~ (p=0.971 n=10)
RuleIsIdentical-4     5.355m ± 2%   5.274m ± 1%  -1.52% (p=0.001 n=10)
GetChecksForEntry-4   112.2m ± 1%   112.3m ± 1%       ~ (p=0.684 n=10)
geomean               131.0m        130.8m       -0.13%

                    │     old.txt     │                new.txt                 │
                    │      B/op       │     B/op       vs base                 │
GlobFinder-4           7.134Mi ± 0%      7.134Mi ± 0%       ~ (p=0.393 n=10)
GitFinder-4            16.09Mi ± 1%      16.09Mi ± 1%       ~ (p=0.796 n=10)
CheckRules-4          1006.4Mi ± 0%     1006.0Mi ± 0%       ~ (p=0.684 n=10)
RuleIsIdentical-4        0.000 ± 0%        0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4    56.55Mi ± 0%      56.55Mi ± 0%       ~ (p=0.315 n=10)
geomean                             ²                  -0.01%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                    │    old.txt    │               new.txt                │
                    │   allocs/op   │  allocs/op   vs base                 │
GlobFinder-4          111.0k ± 0%     111.0k ± 0%       ~ (p=1.000 n=10)
GitFinder-4           148.7k ± 0%     148.7k ± 0%       ~ (p=0.210 n=10)
CheckRules-4          14.56M ± 0%     14.56M ± 0%       ~ (p=0.684 n=10)
RuleIsIdentical-4      0.000 ± 0%      0.000 ± 0%       ~ (p=1.000 n=10) ¹
GetChecksForEntry-4   916.3k ± 0%     916.3k ± 0%       ~ (p=0.219 n=10)
geomean                           ²                -0.00%                ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/cloudflare/pint/internal/parser
        │   old.txt   │            new.txt            │
        │   sec/op    │   sec/op     vs base          │
Parse-4   16.45m ± 4%   16.06m ± 1%  ~ (p=0.075 n=10)

        │   old.txt    │            new.txt             │
        │     B/op     │     B/op      vs base          │
Parse-4   6.306Mi ± 0%   6.306Mi ± 0%  ~ (p=0.085 n=10)

        │   old.txt   │             new.txt             │
        │  allocs/op  │  allocs/op   vs base            │
Parse-4   102.7k ± 0%   102.7k ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

pkg: github.com/cloudflare/pint/internal/parser/source
               │   old.txt   │            new.txt            │
               │   sec/op    │   sec/op     vs base          │
LabelsSource-4   5.717m ± 1%   5.754m ± 1%  ~ (p=0.739 n=10)

               │   old.txt    │            new.txt             │
               │     B/op     │     B/op      vs base          │
LabelsSource-4   4.442Mi ± 0%   4.440Mi ± 0%  ~ (p=0.247 n=10)

               │   old.txt   │            new.txt            │
               │  allocs/op  │  allocs/op   vs base          │
LabelsSource-4   36.35k ± 0%   36.35k ± 0%  ~ (p=0.524 n=10)

pkg: github.com/cloudflare/pint/internal/promapi
                    │   old.txt   │            new.txt            │
                    │   sec/op    │   sec/op     vs base          │
QueryCacheOnlySet-4   104.8n ± 2%   105.6n ± 1%  ~ (p=0.171 n=10)

                    │  old.txt   │            new.txt             │
                    │    B/op    │    B/op     vs base            │
QueryCacheOnlySet-4   64.00 ± 0%   64.00 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

                    │  old.txt   │            new.txt             │
                    │ allocs/op  │ allocs/op   vs base            │
QueryCacheOnlySet-4   1.000 ± 0%   1.000 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

@prymitive prymitive merged commit 084cbf7 into main Apr 2, 2026
20 checks passed
@prymitive prymitive deleted the query branch April 2, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants