Skip to content

DO NOT LAND replace atob/btoa with Buffer.from #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
threepointone wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DO NOT LAND replace atob/btoa with Buffer.from #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/root.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe('root loader', () => {
{ ...payload, exp: Math.round(inFiveMinutes.getTime() / 1000) },
signature,
]
.map((s) => btoa(JSON.stringify(s)))
.map((s) => Buffer.from(JSON.stringify(s)).toString('base64'))
.join('.')}`

const url = new URL('https://orange.cloudflare.dev/')
Expand Down
2 changes: 1 addition & 1 deletion app/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export const loader = async ({ request, context }: LoaderFunctionArgs) => {
if (!CF_Authorization) return defaultResponse

const [, payload] = CF_Authorization.split('.')
const data = JSON.parse(atob(payload))
const data = JSON.parse(Buffer.from(payload, 'base64').toString())
const expires = new Date(data.exp * 1000)
const now = new Date()
if (addOneDay(now) > expires) {
Expand Down