fix: save service token ID for reliable cleanup during e2e teardown #166
+32
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2026 22:27
Previously, the stop script tried to find service tokens by name which could fail if names didn't match exactly. Now we: 1. Save the service token ID (UUID) during start 2. Delete by ID during stop (deterministic and reliable) 3. Keep name-based fallback for backwards compatibility This prevents service token accumulation from failed/partial teardowns.
0.0.63 has issues
andreasjansson
force-pushed
the
fix/cleanup-service-tokens
branch
from
4a17720 to
8088e73
Compare
E2E Test Recording (telegram)❌ Tests failed
|
E2E Test Recording (discord)❌ Tests failed
|
E2E Test Recording (base)❌ Tests failed
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the stop script tried to find service tokens by name which could fail if names didn't match exactly. Now we:
This prevents service token accumulation from failed/partial teardowns.