fix(behavior): Respect DEV/E2E modes when mapping gateway token #148
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dejely
changed the title
Author
|
Hello, Just wanted to bump this in case it slipped through, happy to adjust the approach if needed (refactoring, changes, etc.) . Thanks for maintaining the project guys :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #147 - DEV_MODE does not actually disable gateway token use in container (Behavior mismatch)
Changes
Adjusted gateway token handling so it’s skipped in both
DEV_MODEandE2E_TEST_MODE, and added corresponding unit tests to lock in the behavior. This keeps dev/E2E flows from unintentionally enabling token auth when a token is present.env.tsskips mappingMOLTBOT_GATEWAY_TOKENwhenDEV_MODEorE2E_TEST_MODEis trueTesting: