chore: provide simplified interface to read/write CE for both binary and structured even formats #255
+556
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
structured even formats Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
xSAVIKx
reviewed
Dec 17, 2025
| def from_binary_event( | ||
| message: HTTPMessage, | ||
| event_format: Format | None = None, | ||
| ) -> BaseCloudEvent: |
Member
There was a problem hiding this comment.
this should probably return CloudEvent and not BaseCloudEvent.
Signed-off-by: Tudor Plugaru <plugaru.tudor@protonmail.com>
Author
|
@xSAVIKx if it's all good after last commit, please merge if you'll approve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@xSAVIKx let me know what are your thoughts
One line description for the changelog