DBT-747: Stop support for views materialization in dbt-impala#184
Open
vamshikolanu wants to merge 3 commits intomasterfrom
Open
DBT-747: Stop support for views materialization in dbt-impala#184vamshikolanu wants to merge 3 commits intomasterfrom
vamshikolanu wants to merge 3 commits intomasterfrom
Conversation
added 3 commits
October 11, 2023 09:25
|
I can only say that support for view materialization is a must. Removing it would only make this adapter unusable. 🙁 |
|
Would it be better to implement a new argument/feature to skip the macro if needed instead of removing the whole code for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Currently, there is no easy way to differentiate between tables and views in impala. The current query for list_relations_without_caching is not optimized; hence it started failing for larger number of tables.
Internal Jira ticket number or external issue link:
https://jira.cloudera.com/browse/DBT-747
Testing procedure/screenshots(if appropriate):
https://gist.github.com/vamshikolanu/e77a968cc7a9631390c2ed6f957f60c4
Checklist before requesting a review