LITE-33682 Ensure certs temp folders are created once#122
Merged
arnaugiralt merged 1 commit intomasterfrom Mar 2, 2026
Merged
Conversation
|
There was a problem hiding this comment.
Pull request overview
This pull request modifies the certificate file management in EgressProxyClient to reuse certificate files across multiple client instances instead of creating new temporary files each time. The change aims to optimize file system operations by writing certificate files only once per unique certificate content.
Changes:
- Replaced
_create_temp_cert_filewith_create_cert_filethat uses fixed filenames in the temp directory - Added caching logic to check if file exists with same content before rewriting
- Updated tests to verify the new deterministic file path behavior and file reuse across multiple client instances
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| connect/eaas/core/egress_proxy.py | Implements new _create_cert_file method with fixed filenames and content-based caching logic |
| tests/connect/eaas/core/test_egress_proxy.py | Updates existing tests and adds new tests for deterministic paths, write-once behavior, content change detection, and cross-client file reuse |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arnaugiralt
approved these changes
Feb 27, 2026
arnaugiralt
deleted the
LITE-33682-ensure-certs-temp-folders-are-created-once
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.