LITE-33618: Replace deprecated pkg_resources with importlib.resources for setuptools >= 82 compatibility#121
Merged
arnaugiralt merged 2 commits intomasterfrom Mar 2, 2026
Merged
Conversation
|
|
…ools >= 82 compatibility
arnaugiralt
force-pushed
the
cr/LITE-33618
branch
from
a313064 to
04f4156
Compare
jonatrios
previously approved these changes
Feb 27, 2026
qarlosh
reviewed
Feb 27, 2026
…ertions with deterministic data
arnaugiralt
force-pushed
the
cr/LITE-33618
branch
from
04f4156 to
9e28af3
Compare
|
qarlosh
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extensions fail at runtime when
setuptools >= 82is installed becausepkg_resourceshas been removed.ApplicationBase.get_descriptor()usespkg_resources.resource_stream()to loadextension.json, which breaks with newersetuptoolsversions. The fix is to replace it withimportlib.resources.files()from the standard library (available since Python 3.9), eliminating the implicitsetuptoolsdependency entirely.Also refactored some brittle tests in test_helpers.