fix(clouseau): indexing for document fields of unrecognized types#129
Merged
pgj merged 1 commit intocloudant-labs:mainfrom Jan 26, 2026
Merged
Conversation
In 312656f, a distinction between each supported type has been introduced but there was no case defined for values with unrecognized types. This change broke the compatibility with the 2.x line of releases because such instances will make the process crash, while originally there should have been only a warning issued in the logs and the field in question should have been ignored. Restore this case from the 2.x code base and while there, merge all the similar cases (about handling fields with various number types) since they share the same body. They could be broken down to further cases later if there is a specific reason to do so.
rnewson
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 312656f, a distinction between each supported type has been introduced but there was no case defined for values with unrecognized types. This change broke the compatibility with the 2.x line of releases because such instances will make the process crash, while originally there should have been only a warning issued in the logs and the field in question should have been ignored.
Restore this case from the 2.x code base and while there, merge all the similar cases (about handling fields with various number types) since they share the same body. They could be broken down to further cases later if there is a specific reason to do so.