Conversation
Finicity requires whitelisted IP addresses, so putting a proxy in front of your web workers makes that easier to manage.
cloocher
requested changes
Oct 7, 2016
Owner
cloocher
left a comment
cloocher
left a comment
There was a problem hiding this comment.
all looks good except backward incompatible change to not use snakecase format.
| data.force_encoding('UTF-8') | ||
| $stdout.puts(data) if @verbose | ||
| @parser ||= XmlHasher::Parser.new(snakecase: true, ignore_namespaces: true) | ||
| @parser ||= XmlHasher::Parser.new(snakecase: false, ignore_namespaces: true) |
Owner
There was a problem hiding this comment.
This change is not backward compatible since might break code that relies on default snakecase format. If you need non-snakecase format, then add a new option to turn snakecase on or off.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finicity requires whitelisted IP addresses, so putting
a proxy in front of your web workers makes that easier
to manage.