Pass collectDelay arg to Clinic Doctor/Flame

[DylanC]

Related to this PR:

Doctor
clinicjs/node-clinic-doctor#295

Flame
clinicjs/node-clinic-flame#107
0x
davidmarkclements/0x#222

BubbleProf - Will be separate from this change
clinicjs/node-clinic-bubbleprof#346

The "--collect-delay" arg will be passed in with the arguments and allow the collection of data to be delayed.

[DylanC]

Once this is working for all three I will need to update the parameter from -t to --on-timeout.

[DylanC]

@jasnell
This feature may not work for BubbleProf. Discovered this is difficult/maybe not possible when discussing with @goto-bus-stop. The timeout creates an async entry that BubbleProf can't seem to track. The whole design of BubbleProf relies on a valid root sourceNode that the grouped child Nodes can trace back to.

Will need to think about a solution or only offer the time delay for Doctor and Flame.

[jasnell]

Yeah it's one of the key limitations of bubbleprof I'd say. That that one who may need to collect everything but figure out a way to reasonably filter during the analysis based on timestamp.

[DylanC]

@jasnell - Alright, I'll look into this some more and see what could be possible.

[jasnell]

For now, I'd say limit the timeout feature to doctor and flame an set the bubbleprof support as a separate task.

[DylanC]

@goto-bus-stop - Can I get you to review this and related PR's at some stage today?

[DylanC]

@jasnell - Updated with 0x draft PR.

[goto-bus-stop]

We should really only merge PRs like this once the other packages have been released, so we don't depend on temporary branches in the package.json

[DylanC]

Ah yes! Makes sense!

[ErisDS]

Can the revert be reverted? This would be super useful...