Skip to content

fix: select first tab with differences by default in model-check report #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrispcampbell merged 1 commit into from
Feb 17, 2026
Merged

fix: select first tab with differences by default in model-check report #780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/check-ui-shell/src/components/summary/summary-vm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,9 @@ export function createSummaryViewModel(
addTabItem('comps-by-dataset', 'Comparisons by dataset', byDatasetTabInfo)
}

// Select the first tab that has differences by default; if no differences, show the
// first ("Checks") tab by default
const initialTabIndex = tabItems.findIndex(item => get(item.subtitle) !== 'all clear')
// Select the first tab that has differences by default, i.e., the first tab with a status
// other than "passed". If no differences, show the first ("Checks") tab by default.
const initialTabIndex = tabItems.findIndex(item => get(item.subtitleClass) !== 'status-color-passed')
const tabBarViewModel = new TabBarViewModel(tabItems, initialTabIndex >= 0 ? initialTabIndex : 0)

// Create a map of all test summaries for the baseline (all inputs at default) scenario.
Expand Down