Skip to content

feat: enhance QR code generation and input handling#21

Merged
nielthiart merged 1 commit intomainfrom
various
May 31, 2025
Merged

feat: enhance QR code generation and input handling#21
nielthiart merged 1 commit intomainfrom
various

Conversation

@nielthiart
Copy link
Contributor

  • Updated QRCodeController to use a textarea for input instead of an input field for better user experience.
  • Implemented debouncing for input changes to optimize QR code generation.
  • Removed unnecessary SVG sanitization functions and adjusted SVG handling in QR code rendering.
  • Added default debounce delay option in QRCodeController.
  • Improved error handling in the application initialization process with a more structured error message display.
  • Removed inline css again.
  • Updated Vite configuration to include plugins for single file output and minification, along with CSP policies for security.

- Updated QRCodeController to use a textarea for input instead of an input field for better user experience.
- Implemented debouncing for input changes to optimize QR code generation.
- Removed unnecessary SVG sanitization functions and adjusted SVG handling in QR code rendering.
- Added default debounce delay option in QRCodeController.
- Improved error handling in the application initialization process with a more structured error message display.
- Removed inline css again.
- Updated Vite configuration to include plugins for single file output and minification, along with CSP policies for security.
Copilot AI review requested due to automatic review settings May 31, 2025 13:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances QR code generation and input handling, optimizes asset delivery through Vite configuration updates, and improves application error handling and styling.

  • Replaces an input field with a textarea and adds input debouncing in QRCodeController.
  • Removes SVG sanitizing functions and adjusts QR code rendering logic.
  • Updates Vite configuration and package scripts to support single file output, minification, and CSP policies.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
vite.config.ts Added plugins for single file output and minification; updated CSP policy with style-src.
src/utils/svg-sanitizer.ts Removed unused SVG sanitization functions.
src/style.css Added global styles including layout and responsive styles.
src/main.ts Improved error message rendering using DOM APIs.
src/core/qr-generator.ts Updated QR generation options by disabling XML declaration.
src/controllers/qr-code-controller.ts Changed input handling to use a textarea with debouncing; removed SVG sanitization.
package.json Updated linting and dependency configuration.
index.html Removed inline CSS and switched input field to textarea; adjusted script loading.
.stylelintrc.json Added configuration for stylelint.

@nielthiart nielthiart merged commit bb76889 into main May 31, 2025
1 check passed
@nielthiart nielthiart deleted the various branch May 31, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant