Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances interactive styling for .qr-code-link and removes legacy styles from cards, footer, and error messages.
- Added smooth
box-shadowtransitions for hover, active, and focus-visible states on.qr-code-link. - Removed previous hover/focus/active shadow styles and transition from
.card. - Dropped the footer’s explicit
font-sizeand the error message’stext-align.
Comments suppressed due to low confidence (3)
index.html:180
- [nitpick] The footer’s font size has been removed, which could lead to inconsistent typography. Verify that all footer text still matches the intended design scale.
font-size: 0.875em;
index.html:190
- Removing
text-align: centerfrom.error-messagechanges its layout. Confirm whether error messages should remain centered to match the form layout.
text-align: center;
index.html:96
- Removing the card’s
transitionand related hover/focus styles means users lose interactive feedback. If this was not intentional, restore these rules or migrate the interaction to a new component.
transition: box-shadow 0.3s ease;
| box-shadow: 0 2px 4px rgb(0 0 0 / 30%); | ||
| } | ||
|
|
||
| .qr-code-link:focus-visible { |
There was a problem hiding this comment.
Because the plain :focus rule comes later, it will override the :focus-visible box-shadow. Consider placing :focus-visible after :focus or increasing its specificity to ensure keyboard focus styling isn’t overridden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.