Skip to content

update hover and focus style#20

Merged
nielthiart merged 1 commit intomainfrom
shadow
May 31, 2025
Merged

update hover and focus style#20
nielthiart merged 1 commit intomainfrom
shadow

Conversation

@nielthiart
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings May 31, 2025 06:46
@nielthiart nielthiart merged commit 52473ca into main May 31, 2025
1 check passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances interactive styling for .qr-code-link and removes legacy styles from cards, footer, and error messages.

  • Added smooth box-shadow transitions for hover, active, and focus-visible states on .qr-code-link.
  • Removed previous hover/focus/active shadow styles and transition from .card.
  • Dropped the footer’s explicit font-size and the error message’s text-align.
Comments suppressed due to low confidence (3)

index.html:180

  • [nitpick] The footer’s font size has been removed, which could lead to inconsistent typography. Verify that all footer text still matches the intended design scale.
        font-size: 0.875em;

index.html:190

  • Removing text-align: center from .error-message changes its layout. Confirm whether error messages should remain centered to match the form layout.
        text-align: center;

index.html:96

  • Removing the card’s transition and related hover/focus styles means users lose interactive feedback. If this was not intentional, restore these rules or migrate the interaction to a new component.
        transition: box-shadow 0.3s ease;

box-shadow: 0 2px 4px rgb(0 0 0 / 30%);
}

.qr-code-link:focus-visible {
Copy link

Copilot AI May 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the plain :focus rule comes later, it will override the :focus-visible box-shadow. Consider placing :focus-visible after :focus or increasing its specificity to ensure keyboard focus styling isn’t overridden.

Copilot uses AI. Check for mistakes.
@nielthiart nielthiart deleted the shadow branch May 31, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant