Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a CSS class to the error message container to enable styling.
- Assigns
error-messageclass to the dynamically created error<div>.
Comments suppressed due to low confidence (1)
src/controllers/qr-code-controller.ts:167
- Add or update a unit/integration test to verify that the error
<div>is rendered with theerror-messageclass when an error occurs.
errorDiv.className = 'error-message';
| // Clear container and create error message safely | ||
| this.elements.container.innerHTML = ''; | ||
| const errorDiv = document.createElement('div'); | ||
| errorDiv.className = 'error-message'; |
There was a problem hiding this comment.
[nitpick] Consider using errorDiv.classList.add('error-message') instead of setting className directly to avoid inadvertently removing any existing classes on the element.
Suggested change
| errorDiv.className = 'error-message'; | |
| errorDiv.classList.add('error-message'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.