Propose Fix: Syntax Error, Mismatch vector, Mismatch XML and Yang #646
Open
bhumong wants to merge 4 commits intoclicon:masterfrom
Open
Propose Fix: Syntax Error, Mismatch vector, Mismatch XML and Yang #646bhumong wants to merge 4 commits intoclicon:masterfrom
bhumong wants to merge 4 commits intoclicon:masterfrom
Conversation
fix: unsupport translate() inside when in yang parser
sync from clicon/clixon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request related propose fix that I open in PR-641.
This pull request introduces several improvements and bug fixes across the codebase, focusing on enhanced error handling, prevention of double-free issues in RESTCONF connections and streams, improved YANG grouping resolution, and better XPath evaluation and parsing. These changes aim to make the system more robust, easier to debug, and more standards-compliant.
Error Handling and Debugging Enhancements:
Memory Safety and Double-Free Prevention:
sd_freedandrc_closed) torestconf_stream_dataandrestconf_connstructures, along with associated logic, to prevent double-free and double-close scenarios in RESTCONF HTTP/2 streams and SSL socket connections. [1] [2] [3] [4] [5] [6]YANG Grouping Resolution Improvements:
ys_grouping_resolveto attempt resolution via the original YANG statement if the initial lookup fails, improving compatibility with YANG modules that use grouping inheritance or shadowing. [1] [2]XPath Parsing and Evaluation Enhancements:
/in XPath expressions to better handle tokenization and state transitions. [1] [2]text()node tests by returning parent nodes with body content, and expanded string comparison support for various relational operators. [1] [2]translate()XPath function is always treated as implemented in the parser and evaluator, preventing unnecessary downgrades or errors when optional functions are disabled. [1] [2] [3]YANG Identityref Namespace Handling:
identityrefvalues with namespace prefixes, ensuring the necessary namespaces are declared in the output XML if present in the YANG specification.