Skip to content

Comments

cec: support GIVE_OSD_NAME and GIVE_DEVICE_VENDOR_ID cmd#13

Merged
clementperon merged 3 commits intomainfrom
answer_give_osd_vendor_id
Feb 18, 2026
Merged

cec: support GIVE_OSD_NAME and GIVE_DEVICE_VENDOR_ID cmd#13
clementperon merged 3 commits intomainfrom
answer_give_osd_vendor_id

Conversation

@clementperon
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 13:08
@clementperon clementperon force-pushed the answer_give_osd_vendor_id branch from 4e18881 to 7b63fa6 Compare February 18, 2026 13:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds HDMI-CEC support for handling GIVE_DEVICE_VENDOR_ID (0x8C) and GIVE_OSD_NAME (0x46) by parsing these opcodes into domain events and emitting response frames from the daemon.

Changes:

  • Extend CEC parsing/mappings to recognize GIVE_DEVICE_VENDOR_ID and GIVE_OSD_NAME.
  • Add daemon logic to respond with DEVICE_VENDOR_ID (0x87) and SET_OSD_NAME (0x47) frames.
  • Update tests to cover parsing and daemon responses for the new commands.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_daemon_runner.py Adds expected TX frames for vendor-id + OSD-name replies during system request handling.
tests/test_cec_parser.py Verifies new opcodes are parsed into the correct InputEventTypes.
src/devialetctl/infrastructure/cec_adapter.py Adds opcode naming and request-opcode mapping for the new commands.
src/devialetctl/domain/events.py Introduces new InputEventType enum values for vendor-id and OSD-name requests.
src/devialetctl/application/daemon.py Implements response generation and dispatch for the new CEC system requests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@clementperon clementperon force-pushed the answer_give_osd_vendor_id branch from 33c8c26 to fa8e62a Compare February 18, 2026 13:22
@clementperon clementperon merged commit 0be34ed into main Feb 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant