cec: support GIVE_OSD_NAME and GIVE_DEVICE_VENDOR_ID cmd#13
Merged
clementperon merged 3 commits intomainfrom Feb 18, 2026
Merged
cec: support GIVE_OSD_NAME and GIVE_DEVICE_VENDOR_ID cmd#13clementperon merged 3 commits intomainfrom
clementperon merged 3 commits intomainfrom
Conversation
4e18881 to
7b63fa6
Compare
There was a problem hiding this comment.
Pull request overview
Adds HDMI-CEC support for handling GIVE_DEVICE_VENDOR_ID (0x8C) and GIVE_OSD_NAME (0x46) by parsing these opcodes into domain events and emitting response frames from the daemon.
Changes:
- Extend CEC parsing/mappings to recognize
GIVE_DEVICE_VENDOR_IDandGIVE_OSD_NAME. - Add daemon logic to respond with
DEVICE_VENDOR_ID (0x87)andSET_OSD_NAME (0x47)frames. - Update tests to cover parsing and daemon responses for the new commands.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_daemon_runner.py | Adds expected TX frames for vendor-id + OSD-name replies during system request handling. |
| tests/test_cec_parser.py | Verifies new opcodes are parsed into the correct InputEventTypes. |
| src/devialetctl/infrastructure/cec_adapter.py | Adds opcode naming and request-opcode mapping for the new commands. |
| src/devialetctl/domain/events.py | Introduces new InputEventType enum values for vendor-id and OSD-name requests. |
| src/devialetctl/application/daemon.py | Implements response generation and dispatch for the new CEC system requests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
33c8c26 to
fa8e62a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.