Skip to content

Comments

cli: reduce logging for httpx / httpcore#11

Merged
clementperon merged 2 commits intomainfrom
reduce_logging
Feb 18, 2026
Merged

cli: reduce logging for httpx / httpcore#11
clementperon merged 2 commits intomainfrom
reduce_logging

Conversation

@clementperon
Copy link
Owner

No description provided.

Copilot AI review requested due to automatic review settings February 18, 2026 08:45
@clementperon clementperon merged commit 3991b85 into main Feb 18, 2026
2 of 3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces noisy HTTP client logging in the CLI by overriding the log levels for httpx and httpcore after the CLI logging is configured.

Changes:

  • Set httpx logger level to WARNING in CLI logging configuration.
  • Set httpcore logger level to WARNING in CLI logging configuration.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +96 to 98
logging.getLogger("httpcore").setLevel(logging.WARNING)


Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the httpx/httpcore logger levels to WARNING unconditionally can increase verbosity when the requested CLI log level is higher (e.g. ERROR/CRITICAL). In Python logging, parent/root logger levels do not filter propagated records—so a child logger at WARNING will still emit warnings via the root handler even if the root logger is set to ERROR. Consider setting these libraries to max(requested_level, WARNING) (i.e., keep them at least WARNING, but never below the user-requested threshold).

Copilot uses AI. Check for mistakes.
@clementperon clementperon deleted the reduce_logging branch February 20, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant