Skip to content

Fix nodiscard warnings #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cleishm merged 1 commit into from
Mar 24, 2026
Merged

Fix nodiscard warnings #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/idfxx_nvs/examples/nvs_storage/main/main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ extern "C" void app_main() {
logger.info("Erased key 'to_erase'");

try {
handle.get_value<uint32_t>("to_erase");
(void)handle.get_value<uint32_t>("to_erase");
} catch (const std::system_error& e) {
logger.info("Expected error reading erased key: {}", e.what());
}
Expand Down
6 changes: 3 additions & 3 deletions components/idfxx_queue/include/idfxx/queue.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ class queue {
* @note Only available when CONFIG_COMPILER_CXX_EXCEPTIONS is enabled.
* @throws std::system_error with idfxx::errc::timeout if the queue remains empty.
*/
[[nodiscard]] T receive() { return unwrap(try_receive()); }
T receive() { return unwrap(try_receive()); }

/**
* @brief Receives an item from the queue with a timeout.
Expand All @@ -394,7 +394,7 @@ class queue {
* for the duration.
*/
template<typename Rep, typename Period>
[[nodiscard]] T receive(const std::chrono::duration<Rep, Period>& timeout) {
T receive(const std::chrono::duration<Rep, Period>& timeout) {
return unwrap(try_receive(timeout));
}

Expand All @@ -412,7 +412,7 @@ class queue {
* until the deadline.
*/
template<typename Clock, typename Duration>
[[nodiscard]] T receive_until(const std::chrono::time_point<Clock, Duration>& deadline) {
T receive_until(const std::chrono::time_point<Clock, Duration>& deadline) {
return unwrap(try_receive_until(deadline));
}
#endif
Expand Down
Loading