[BASE] Plonk#49

Open

vesselinux wants to merge 161 commits intodevelopfrom

Commits on Oct 26, 2022

added TAGS to .gitignore

Vesselin Velichkov
authored and
dtebbs
committed
added BLS12-381 curve to CMakeLists.txt

Vesselin Velichkov
authored and
dtebbs
committed
added test for plonk in CMakeLists.txt

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented common untility functions

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented circuit description class

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented srs class

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented prover class

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented verifier class

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added tests and test vector values

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added tests and test vector values; minor fixes to formatting using higher version clang-format-11

Vesselin Velichkov
authored and
dtebbs
committed
plonk: fixed formatting with clang-format-11

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added updated version of libff with support for curve bls12-381

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced all DEBUG guards with DEBUG_PLONK to avoid redeclaration error

Vesselin Velichkov
authored and
dtebbs
committed
plonk: fixed unused variable compilation error

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed unused Lagrange basis input parameter from function plonk_compute_public_input_polynomial and plonk_interpolate_over_lagrange_basis

Vesselin Velichkov
authored and
dtebbs
committed
plonk: changed include-s of local files to be added with "" rather than <>

Vesselin Velichkov
authored and
dtebbs
committed
plonk: moved libff and libfqfft include headers from test_plonk.cpp to example.hpp

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed local alias of polynomial and replaced with the global definition by including polynomial.hpp

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed the template parameter ppT from the plonk_example class as this class is specific to the BLS12_381 curve. Added an exception check for ppT == bls12_381_pp before each creation of a n…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added missing #include <vector> to polynomial.hpp and included polynomial.hpp with "" rather than <> in plonk

Vesselin Velichkov
authored and
dtebbs
committed
plonk: renamed NUM_HGEN to NUM_HSETS and fixed corresponding comment

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed an extra copy of f_points in plonk_interpolate_polynomial_from_points for improved efficiency

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added empty line between all class members for improved readability

Vesselin Velichkov
authored and
dtebbs
committed
plonk: moved function plonk_curcuit_description_from_example to test_plonk.cpp as it is dependent on the particular test values of the example we use for debug.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added the maximum degree of the monomials in the usrs to be an input parameter to function plonk_usrs_derive_from_secret that creates the usrs object

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed macro MAX_DEGREE specifying the maximum monomial degree supported in the USRS. This maximum degree is now input as a parameter to plonk_usrs_derive_from_secret that creates the USRS.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added constructor to structure circuit_t

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added clarification of the purpose of the circuit_t strcuture in the comment section of circuit.hpp

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed unused function check_field_element

Vesselin Velichkov
authored and
dtebbs
committed
plonk: improved efficiency in the computation of the roots of unity omega. namely, do not recompute the power from scratch each time, but iteratively multiply by omega_base at each iteration.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: corrected description of function plonk_compute_roots_of_unity_omega in comments

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added minor correction of "encrypted" to "encoded" in comments

Vesselin Velichkov
authored and
dtebbs
committed
plonk: modified function plonk_compute_roots_of_unity_omega to allocate space for the 2d vector omega inside itself rather than by the caller. the motivation is to avoid errors from passing inputs …

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced function plonk_roots_of_unity_omega_to_subgroup_H with plonk_multiplicative_subgroups_H_k1H_k2H. the latter recomputes the vector of omega roots in order to avoid passing it as an i…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: fixed typo in comments

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed extra output specifed in the Doxygen comments to plonk_prover::round_zero

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced type of constant parameter nwitness from int to const size_t

Vesselin Velichkov
authored and
dtebbs
committed
plonk: created a separate struct to contain all hashes of the communication transcript produced by the prover. added it as input to prover::compute_proof. removed all variables (alpha, beta, gamma,…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added the witness vlaues to be passed as an input to prover::compute_proof by the caller. previously the witness was hard-coded from the example class which is used only for debug.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented unit tests for prover rounds 1,2,3,4,5.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: broke down test_plonk into three separate unit tests: test_plonk_srs, test_plonk_prover, test_plonk_verifier

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added the hashes of the communication transcript (challenges alpha, beta, gamma, etc.) as inputs to verifier verify_proof and step_four to be computed by the caller. previously it was hard-c…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implemented unit tests for verifier steps 1-12

Vesselin Velichkov
authored and
dtebbs
committed
plonk: moved all constructors from the *.hpp files to the corresponding *.tcc files

Vesselin Velichkov
authored and
dtebbs
committed
plonk: renamed plonk.* to utils.* to better reflect the content of these files which contain common internal utility functions

Vesselin Velichkov
authored and
dtebbs
committed
plonk: renamed plonk_multiplicative_subgroups_H_k1H_k2H to plonk_compute_cosets_H_k1H_k2H

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed obsolete function plonk_interpolate_over_lagrange_basis

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed exit(EXIT_FAILURE) in several exception handles so that we don't exit the process upon error.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: modified functions plonk_permute_subgroup_H and plonk_compute_permutation_polynomials not to rely on the caller for allocating the correct sizes of the return parameters. those are now alloc…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: renamed input parameter n of plonk_compute_permutation_polynomials and plonk_compute_accumulator to the more expressive num_gates

Vesselin Velichkov
authored and
dtebbs
committed
plonk: fixed typo in comments

Vesselin Velichkov
authored and
dtebbs
committed
plonk: fixed multiple input parameters to prover functions to be passed by const reference in order to save an extra copy

Vesselin Velichkov
authored and
dtebbs
committed
plonk: corrected comment

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added missing reference to the reference Python implementation \[PlonkPy] in comments

Vesselin Velichkov
authored and
dtebbs
committed
plonk: modified plonk_verifier<ppT>::step_four() to directly pass the input parameter transcript_hash to the constructor instead of first copying and then moving.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed check that we are on the BLS12-381 in view of the fact that all example test vectors are defined on this curve. the check is not necessary since there will be an error at the compile…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: remove all all try-catch clauses and let the caller handle the thrown exceptions. addresses issue https://github.com/clearmatics/libsnark/issues/57

Vesselin Velichkov
authored and
dtebbs
committed
plonk: fixed functions plonk_compute_accumulator and plonk_compute_selector_polynomials to allocate the size of their return values inside of the function i.e. not to rely on the caller to pass inp…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed storing the pre-computed Lagrange basis as part of the srs. instead compute it on-the-fly as we need it. addresses issue https://github.com/clearmatics/libsnark/issues/55

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added the libfqfft domain parameter as part of the srs. correspondingly function plonk_compute_lagrange_basis was modified to accept domain as an input parameter (from the srs) thus removing…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added the 0-th Lagrange basis polynomial in the SRS instead of computing the full basis on demand (we only use the 0-th polynomial from the basis); addresses PR comment https://github.com/cl…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed unused function plonk_compute_lagrange_basis()

Vesselin Velichkov
authored and
dtebbs
committed
plonk: updated depedent library libff to latest version

Vesselin Velichkov
authored and
dtebbs
committed
plonk: move print_vector function to libff (cf. Issue https://github.com/clearmatics/libsnark/issues/59 , PR https://github.com/clearmatics/libsnark/pull/64)

Vesselin Velichkov
authored and
dtebbs
committed
plonk: updated libff from 6dee67e to f9a588c in order to include the newly added print_vector function (PR https://github.com/clearmatics/libsnark/pull/64)

Vesselin Velichkov
authored and
dtebbs
committed
plonk: prepended explicitly libff:: to every call to print_vector which is now part of libff.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced structure transcript_hash_t with class transcript_hasher that makes a call to hash function. for the moment it directly returns the expected hash values for the purposes of testing.…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: implementation of transcript hasher, addressing issue #56 and PR #61.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: moved the initialisation of the array of expected hash values to the transcript hasher constructor (cf. https://github.com/clearmatics/libsnark/pull/61#discussion_r935463921); added exceptio…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed catching the invalid size exception within the get_hash function. the caller must handle it.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed computation of the challenge u at the end of the prover process since u is not used by the prover anyway. removed the automatic clearing of the hasher buffer inside get_hash. the cal…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: use std::count to check if the hasher buffer is of valid length instead of explicitly checking all valid lengths.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed doc comments /// from cpp and tcc files. left only in headers. addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r949757635

Vesselin Velichkov
authored and
dtebbs
committed
plonk: moved constructor of transcipt_hasher class as first method in the class. addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r949761293

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added back the computation of the multipoint challenge u in the last round of the prover. we need to compute u even though we are not using it in the prover in order to make sure that the pr…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: in transcript_hasher removed the private buffer variable as an input parameter to the constructor. only the object has access to the buffer now. addresses PR #61 comment https://github.com/c…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: moved function signature comments from .tcc to .hpp files only; removed redundant comments indicating class constructors' other minor comments formatting

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced test values in transcript_hasher with values from the plonk_example class; addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r964175573 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed redundant debug info and unreachable debug checks. addresses PR# 61.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: set transcript hasher constants alpha, beta, ... to type const. see PR #61

Vesselin Velichkov
authored and
dtebbs
committed
plonk: added the transcript_hasher class as an additional specialization parameter to the prover and verifier classes. moved the current transcript_hasher class from files srs.* to its own files un…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: created a new transcript_hasher.hpp file with just a comment that describes the interface of a common transcript hasher. addresses step 1. from comment https://github.com/clearmatics/libsnar…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced the checks over all valid buffer lengths in the transcript hasher with a while loop directly finding the correct length; addresses https://github.com/clearmatics/libsnark/pull/61#di…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced challenge_str map with a vector. addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r968600750 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: combine two error checks that are functionally the same into one. addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r968604416 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: declared const challenge upon assignment in bls12_381_test_vector_transcript_hasher::get_hash(). addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r968605915 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed redundant this-> in get_hash. addresses https://github.com/clearmatics/libsnark/pull/61#discussion_r968607769 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: created length and challenge arrays as const members of class bls12_381_test_vector_transcript_hasher initialized in the constructor. addresses https://github.com/clearmatics/libsnark/pull/6…

Vesselin Velichkov
authored and
dtebbs
committed
plonk: amended comments to transcript hasher code according to suggestions in https://github.com/clearmatics/libsnark/pull/61#discussion_r970529544 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: replaced while loop in get_hash with for loop; assert-ed that length and challenge arrays are of same length in transcript hasher constructor; minor edits. addresses lates comments in PR #61 .

Vesselin Velichkov
authored and
dtebbs
committed
plonk: renamed example.tcc to example.cpp. added example.cpp and bls12_381_test_vector_transcript_hasher.cpp to CMakeLists.txt. added several headers to fix compilation errors.

Vesselin Velichkov
authored and
dtebbs
committed
plonk: formatted example.cpp with latest version of clang-format-11

Vesselin Velichkov
authored and
dtebbs
committed
plonk: removed dummy functions for verifier steps 1,2,3

Vesselin Velichkov
authored and
dtebbs
committed

Commits on Oct 31, 2022

plonk: added support for BW6_761, BLS12_377 in CMakeLists.txt
Vesselin Velichkov
committed
plonk: updated depends/libff to latest revision
Vesselin Velichkov
committed
plonk: added domain parameter as input to several functions in prover to avoid recomputing it
Vesselin Velichkov
committed
plonk: removed domain parameter from the srs class
Vesselin Velichkov
committed
plonk: added domain parameter as a new input to multiple functions as a result of changes to several function declarations in prover, verifier and srs
Vesselin Velichkov
committed
plonk: added domain parameter as a new input to multiple functions in utils.*
Vesselin Velichkov
committed
plonk: added domain parameter as an additional input parameter to several functions in verifier
Vesselin Velichkov
committed

Commits on Nov 4, 2022

Commits on Nov 9, 2022

plonk: updated plonk_circuit_description_from_example to accept only gates matrix, wire premutation and public input as inputs (https://github.com/clearmatics/libsnark/issues/83)
Vesselin Velichkov
committed

Commits on Nov 11, 2022

plonk: updated example circuit description in comments in example.hpp
Vesselin Velichkov
committed

Commits on Nov 16, 2022

Commits on Nov 23, 2022

Commits on Nov 25, 2022

plonk: clarified the origin of the constants k1,k2 in comments (https://github.com/clearmatics/libsnark/pull/91#discussion_r1031568957)
Vesselin Velichkov
committed
plonk: changed variables to const (https://github.com/clearmatics/libsnark/pull/91#discussion_r1031580862)
Vesselin Velichkov
committed
plonk: added minor edits to comments
Vesselin Velichkov
committed

Commits on Nov 28, 2022

Commits on Nov 29, 2022

plonk: added functions to generate constants k1,k2 (section 8.1 [GWC19]) and check their validity (addresses issue https://github.com/clearmatics/libsnark/issues/90)
Vesselin Velichkov
committed

Commits on Nov 30, 2022

Commits on Dec 1, 2022

plonk: added unit tests for all curves for the function choosing the k1,k2 constants for plonk
Vesselin Velichkov
committed

Commits on Dec 6, 2022

Commits on Dec 15, 2022

Commits on Jan 10, 2023

Merge pull request #94 from clearmatics/70-plonk-setting-k1-k2
dtebbs
authored

Commits on Jan 17, 2023

Commits on Jan 25, 2023

Merge branch 'develop' into plonk
Vesselin Velichkov
committed
plonk: added dummy transcript hasher specialized for all curves; added unit tests for the simple quadratic residue circuit for all curves (addresses issue https://github.com/clearmatics/libsnark/is…
Vesselin Velichkov
committed

Commits on Feb 3, 2023