Anemoi hash r1cs numstatecolumns#102
Merged
dtebbs merged 5 commits intoanemoi-hash-r1csfrom Jan 23, 2023
Merged
Conversation
vesselinux
force-pushed
the
anemoi-hash-r1cs-numstatecolumns
branch
from
52e2596 to
d9f917c
Compare
dtebbs
suggested changes
Jan 13, 2023
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.hpp
Outdated
Show resolved
Hide resolved
vesselinux
pushed a commit
that referenced
this pull request
Jan 16, 2023
…for different number of columns using class specialization (#102 (comment))
dtebbs
reviewed
Jan 16, 2023
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.hpp
Outdated
Show resolved
Hide resolved
libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.hpp
Outdated
Show resolved
Hide resolved
vesselinux
pushed a commit
that referenced
this pull request
Jan 17, 2023
…ter from all anemoi_permutation_mds::permutation_mds functions (#102 (comment))
Contributor
|
Addresses #105 |
vesselinux
pushed a commit
that referenced
this pull request
Jan 17, 2023
added 4 commits
January 17, 2023 20:45
…me and binary fields (#77, #65 (comment), #65 (comment)) - resolved conflicts after rebase onto anemoi-hash-r1cs
…ent number of columns using class specialization (#102 (comment))
…ter from all anemoi_permutation_mds::permutation_mds functions (#102 (comment))
vesselinux
force-pushed
the
anemoi-hash-r1cs-numstatecolumns
branch
from
5eb8ac5 to
85bb953
Compare
…_mds::permutation_mds after rebase onto anemoi-hash-r1cs
Collaborator
Author
|
Rebased on
added as comments in file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase anemoi-hash-r1cs-numstatecolumns onto base branch anemoi-hash-r1cs. See PR #79 [FROZEN] which was automatically closed after deleting branch anemoi-hash-r1cs-parametrization . This branch implements specialised implementations of multiplication by the MDS matrix for valid values of
NumStateColumns_L. In contrast, the method used in the base branch is a single function for all matrix sizes (1,2,3,4) with static assert check on the dimensions (https://github.com/clearmatics/libsnark/blob/anemoi-hash-r1cs/libsnark/gadgetlib1/gadgets/hashes/anemoi/anemoi_components.tcc#L326). See the last bullet in #77 and #65 (comment) .