log if modal does not exist on modalButton and modalLink #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds defensive logging to modal components when the modal attribute is misconfigured, and upgrades the project from Java 17 to Java 25.
- Added informative logging for invalid
modalattribute values inModalButtonComponentandModalLinkComponent - Upgraded project Java version from 17 to 25 in build configuration
- Bumped artifact version to 6.0.9-SNAPSHOT
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ModalLinkComponent.java | Added logger and else-branch logging for invalid modal attribute |
| ModalButtonComponent.java | Added logger and else-branch logging for invalid modal attribute |
| pom.xml | Updated Java version property from 17 to 21 |
| .idea/misc.xml | Updated IDE project JDK configuration to version 25 |
| .github/workflows/ci.yml | Updated CI workflow Java version to 25 |
Files not reviewed (1)
- .idea/misc.xml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.