Progressbar component #26
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearfeld
requested changes
Nov 17, 2024
| <div> | ||
| <ExampleBlock | ||
| title="Success" | ||
| description="Green progress bar." |
Owner
There was a problem hiding this comment.
A progress bar is only green when it reaches the success (completed state).
| <div> | ||
| <ExampleBlock | ||
| title="Danger" | ||
| description="Red progress bar." |
Owner
There was a problem hiding this comment.
A progress bar only stops and turns red if there's an error.
| <ExampleBlock | ||
| title="Default" | ||
| description="" | ||
| description="Blue progress bar." |
Owner
There was a problem hiding this comment.
A progress bar that is currently in progress and hasn't completed or encountered an error is blue.
Collaborator
Author
|
Made changes, please check again. |
clearfeld
approved these changes
Nov 18, 2024
| <ExampleBlock | ||
| title="Danger" | ||
| description="Red progress bar." | ||
| description="A progress bar only stops and turns red if there's an error." |
Owner
There was a problem hiding this comment.
A bit of rewording would be good, since the component doesn't automatically change to red / danger if there's an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.