CS-51 - Remove dependency on dynamodb.yml from cc_dynamodb3#27
CS-51 - Remove dependency on dynamodb.yml from cc_dynamodb3#27Derrick Petzold (dpetzold) wants to merge 1 commit intomasterfrom
Conversation
Derrick Petzold (dpetzold)
force-pushed
the
core/CS-51-remove-dynamodb-yml-dependency
branch
from
9a790f6 to
b50aabb
Compare
|
Jay O'Conor (@joconor) Brian Zambrano (@brianz) Paul Craciunoiu (@pcraciunoiu) this is ready for review. Also see https://github.com/clearcare/cc_hcl_translator that is what parses the terraform file and https://github.com/clearcare/clearcare/pull/2413 is where the changes were made to clearcare. |
|
👍 Would like to see the tests for clearcare PR #2413 run successfully though. Settings/docker.py is referencing dynamo_tables.yml when it should be dynamo_tables.tf. |
| PyYAML>=3.10 | ||
| schematics==1.1.1 | ||
| redis==2.10.5 | ||
| -e git+git@github.com:clearcare/cc_hcl_translator.git@94f633fbb3412aeb7bba5dd18063845f4ed751a5#egg=hcl_translator |
There was a problem hiding this comment.
Why not give this a version tag? Not a big fan of installing from sha strings that don't give us a clue to any progression of changes. Will we be maintaining a fork of this indefinitely? If so, all the more reason to tag it with a version.
There was a problem hiding this comment.
Going to tag after review!
|
👍 |
Derrick Petzold (dpetzold)
force-pushed
the
core/CS-51-remove-dynamodb-yml-dependency
branch
from
b8a153b to
7f6bde8
Compare
Derrick Petzold (dpetzold)
force-pushed
the
core/CS-51-remove-dynamodb-yml-dependency
branch
3 times, most recently
from
16fde0f to
e51b9d7
Compare
- Removed support for dynamodb.yml. The dynamodb terraform file is now the authorative source of truth for the dynamodb schema information. - Removed support for table creation and updates and there related tests as that is handled by terraform now. - Removed support for retrieving table column information. That will have to be done outside of cc_dynamodb3.
Derrick Petzold (dpetzold)
force-pushed
the
core/CS-51-remove-dynamodb-yml-dependency
branch
from
e51b9d7 to
fcd798d
Compare
3 participants
dynamodb.yml. The dynamodb terraform file is now the authoritative source of truth for the dynamodb schema information.