Fix data set validation when a logger is supplied #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xrotwang
approved these changes
Jan 15, 2025
Contributor
xrotwang
left a comment
xrotwang
left a comment
There was a problem hiding this comment.
Is moving the success = False line above the log_or_raise call strictly necessary?
Contributor
Author
|
No, but I thought if it is in the same place for every instance it makes it easier to spot if one is missing. |
Contributor
Ok. Was just checking my intuition :) |
Contributor
|
Should I make a release of pycldf right away? |
Contributor
Author
|
I think that would be good, since this fix should be pulled in during CI runs. |
Contributor
|
Released with 1.40.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #187