speedup test.py (select pixels by score before loops)#4
Open
kir-dan wants to merge 1 commit intoclcarwin:masterfrom
Open
speedup test.py (select pixels by score before loops)#4kir-dan wants to merge 1 commit intoclcarwin:masterfrom
kir-dan wants to merge 1 commit intoclcarwin:masterfrom
Conversation
rondeaujared
reviewed
Jan 7, 2019
rondeaujared
left a comment
rondeaujared
left a comment
There was a problem hiding this comment.
Changes resulted in ~5-10x speedup on a gtx970, no apparent loss in accuracy or other negative effects noticed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: we check every pixel of image by score (FH * FW loop operations)
After: select which pixels are interesting for us and after that make all operations in loop (~70 loop operations)
Final speedup on test image (only detect function):
246ms -> 79ms