⚡ Bolt: Concurrent message processing

[google-labs-jules]

⚡ Bolt: Concurrent message processing

💡 What: Refactored SatcomForecastCoordinator to process incoming GPS messages concurrently instead of sequentially.
🎯 Why: Previously, if multiple messages were in the inbox, the integration would process them one by one. Each message involves fetching a forecast (HTTP) and sending an email (SMTP), which are slow I/O operations. Sequential processing meant the total time was the sum of all operations.
📊 Impact: Reduces processing time for multiple messages to approximately the time of the slowest single message processing chain. In a benchmark with 5 messages each taking ~0.2s, processing time dropped from ~1.0s to ~0.2s.
🔬 Measurement: Verified with a benchmark test (deleted before commit) simulating network delays. Existing tests pass.

---

PR created automatically by Jules for task 1687543844194200690 started by @clayauld

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

---

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

[github-actions]

📊 Pull Request Analysis Report

🧪 Test Results

Metric	Value
Total Tests	244
✅ Passed	244
❌ Failed	0
⏭️ Skipped	0
💥 Errors	0
📈 Success Rate	100.0%

📋 Coverage Report

Metric	Value
Overall Coverage	81.8%
Total Lines	2792
Covered Lines	2283
Missing Lines	509

📁 File Coverage Breakdown

• __init__.py: 86.0%
• api_cache.py: 83.5%
• api_client.py: 84.5%
• api_config.py: 75.2%
• api_data_processor.py: 78.9%
• api_error_handler.py: 88.9%
• api_formatter.py: 94.2%
• api_models.py: 95.6%
• config_flow.py: 68.5%
• const.py: 100.0%

🎯 Recommendations

---

📊 Analysis generated by GitHub Actions • View detailed test report

[github-actions]

🤖 Automated Code Review

🧪 Test Results

✅ All tests passed! Your changes don't break any existing functionality.

🔍 Linting Results Summary

❌ Black (Code Formatting)

--- /home/runner/work/satcom-forecast/satcom-forecast/custom_components/satcom_forecast/coordinator.py	2025-12-18 19:38:32.020510+00:00
+++ /home/runner/work/satcom-forecast/satcom-forecast/custom_components/satcom_forecast/coordinator.py	2025-12-18 19:38:40.690898+00:00
@@ -117,18 +117,23 @@
             self._data["gps_received_count"] += len(messages)
             _LOGGER.info("Found %d GPS requests to process", len(messages))
 
             # Process messages concurrently
             await asyncio.gather(
-                *(self._process_message(i, msg, len(messages)) for i, msg in enumerate(messages))
+                *(
+                    self._process_message(i, msg, len(messages))
+                    for i, msg in enumerate(messages)
+                )
             )
 
         _LOGGER.debug("Coordinator update cycle completed")
         self.data = self._data.copy()
         return self.data
 
-    async def _process_message(self, i: int, msg: Dict[str, Any], total_messages: int) -> None:
+    async def _process_message(
+        self, i: int, msg: Dict[str, Any], total_messages: int
+    ) -> None:
         """Process a single message."""
         _LOGGER.debug(
             "Processing message %d/%d from %s with coordinates %s, %s",
             i + 1,
             total_messages,
@@ -270,13 +275,11 @@
                         msg["lon"],
                         len(message_parts),
                     )
                     _LOGGER.debug("Updated coordinator data: %s", self._data)
                 else:
-                    _LOGGER.error(
-                        "Failed to send forecast email to %s", msg["sender"]
-                    )
+                    _LOGGER.error("Failed to send forecast email to %s", msg["sender"])
             else:
                 _LOGGER.error(
                     "Failed to fetch forecast for coordinates %s, %s: %s",
                     msg["lat"],
                     msg["lon"],
would reformat /home/runner/work/satcom-forecast/satcom-forecast/custom_components/satcom_forecast/coordinator.py

Oh no! 💥 💔 💥
1 file would be reformatted, 48 files would be left unchanged.

Fix: Run black custom_components/satcom_forecast/ to auto-format your code.

❌ Flake8 (Code Quality)

custom_components/satcom_forecast/coordinator.py:122:89: E501 line too long (97 > 88 characters)
custom_components/satcom_forecast/coordinator.py:129:89: E501 line too long (95 > 88 characters)

Fix: Address the code quality issues shown above. Common fixes:

• Remove unused imports and variables
• Break long lines (88 char limit)
• Add proper spacing around operators

✅ isort (Import Sorting) - PASSED

⚠️ MyPy (Type Checking)

custom_components/satcom_forecast/config_flow.py:212: error: Unused "type: ignore" comment  [unused-ignore]
custom_components/satcom_forecast/config_flow.py:212: error: Untyped decorator makes function "async_get_options_flow" untyped  [untyped-decorator]
custom_components/satcom_forecast/config_flow.py:212: note: Error code "untyped-decorator" not covered by "type: ignore" comment

Fix: Add missing type annotations and fix type errors. Common fixes:

• Add return type annotations: def function() -> ReturnType:
• Add parameter type hints: def function(param: ParamType):
• Import needed types: from typing import List, Dict, Optional

✅ Bandit (Security) - PASSED

🚨 Action Required

Some linting checks failed. Please fix the issues above and push your changes.

Quick Fix Commands:

# Auto-fix formatting and imports
black custom_components/satcom_forecast/ tests/
isort --profile=black custom_components/satcom_forecast/ tests/

# Check for remaining issues
flake8 custom_components/satcom_forecast/ tests/ --max-line-length=88 --extend-ignore=E203,W503

---

This comment was automatically generated by GitHub Actions. Check the Actions tab for detailed logs.