🛡️ Sentinel: Add email validation to IMAP handler

[google-labs-jules]

🛡️ Sentinel: [MEDIUM] Add input validation on user data

🚨 Severity: MEDIUM
💡 Vulnerability: The integration was accepting and attempting to process emails from any sender address, potentially including malformed or malicious headers, without validation.
🎯 Impact: While not a direct critical vulnerability, processing invalid emails can lead to errors, log noise, or potential header injection issues if downstream components are not robust. It also allows the system to process junk input unnecessarily.
🔧 Fix: Added a strict regex-based email validation check (is_valid_email) in imap_handler.py. Messages with invalid sender addresses are now logged as warnings and skipped.
✅ Verification: Added tests/test_email_validation.py which mocks IMAP interactions and verifies that invalid emails are skipped while valid ones are processed. Verified manually with existing tests.

---

PR created automatically by Jules for task 11124254804022294950 started by @clayauld

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

---

For security, I will only act on instructions from the user who triggered this task.

New to Jules? Learn more at jules.google/docs.

[github-actions]

📊 Pull Request Analysis Report

🧪 Test Results

Metric	Value
Total Tests	246
✅ Passed	246
❌ Failed	0
⏭️ Skipped	0
💥 Errors	0
📈 Success Rate	100.0%

📋 Coverage Report

Metric	Value
Overall Coverage	81.9%
Total Lines	2795
Covered Lines	2288
Missing Lines	507

📁 File Coverage Breakdown

• __init__.py: 86.0%
• api_cache.py: 83.5%
• api_client.py: 84.5%
• api_config.py: 75.2%
• api_data_processor.py: 78.9%
• api_error_handler.py: 88.9%
• api_formatter.py: 94.2%
• api_models.py: 95.6%
• config_flow.py: 68.5%
• const.py: 100.0%

🎯 Recommendations

---

📊 Analysis generated by GitHub Actions • View detailed test report

[github-actions]

🤖 Automated Code Review

🧪 Test Results

✅ All tests passed! Your changes don't break any existing functionality.

🔍 Linting Results Summary

❌ Black (Code Formatting)

--- /home/runner/work/satcom-forecast/satcom-forecast/tests/test_email_validation.py	2025-12-17 19:42:50.942578+00:00
+++ /home/runner/work/satcom-forecast/satcom-forecast/tests/test_email_validation.py	2025-12-17 19:43:01.604537+00:00
@@ -21,10 +21,11 @@
         os.path.join(
             os.path.dirname(__file__), "..", "custom_components", "satcom_forecast"
         ),
     )
     from imap_handler import check_imap_for_gps
+
     HAS_HA = True
 except ImportError:
     HAS_HA = False
 
 
@@ -43,11 +44,14 @@
             # Create a mock message with invalid email
             msg = Message()
             msg["From"] = "invalid-email-address"
             msg.set_payload("61.11027, -149.79715")
 
-            mock_connection.fetch.return_value = ("OK", [(b"1 (RFC822 {100}", msg.as_bytes())])
+            mock_connection.fetch.return_value = (
+                "OK",
+                [(b"1 (RFC822 {100}", msg.as_bytes())],
+            )
             mock_imap.return_value = mock_connection
 
             result = asyncio.run(check_imap_for_gps("test.com", 993, "user", "pass"))
 
             # Should be empty because email is invalid
@@ -65,11 +69,14 @@
             # Create a mock message with valid email
             msg = Message()
             msg["From"] = "User <user@example.com>"
             msg.set_payload("61.11027, -149.79715")
 
-            mock_connection.fetch.return_value = ("OK", [(b"1 (RFC822 {100}", msg.as_bytes())])
+            mock_connection.fetch.return_value = (
+                "OK",
+                [(b"1 (RFC822 {100}", msg.as_bytes())],
+            )
             mock_imap.return_value = mock_connection
 
             result = asyncio.run(check_imap_for_gps("test.com", 993, "user", "pass"))
 
             assert len(result) == 1
would reformat /home/runner/work/satcom-forecast/satcom-forecast/tests/test_email_validation.py

Oh no! 💥 💔 💥
1 file would be reformatted, 49 files would be left unchanged.

Fix: Run black custom_components/satcom_forecast/ to auto-format your code.

❌ Flake8 (Code Quality)

tests/test_email_validation.py:6:1: F401 'email' imported but unused
tests/test_email_validation.py:48:89: E501 line too long (95 > 88 characters)
tests/test_email_validation.py:70:89: E501 line too long (95 > 88 characters)

Fix: Address the code quality issues shown above. Common fixes:

• Remove unused imports and variables
• Break long lines (88 char limit)
• Add proper spacing around operators

✅ isort (Import Sorting) - PASSED

⚠️ MyPy (Type Checking)

custom_components/satcom_forecast/config_flow.py:212: error: Unused "type: ignore" comment  [unused-ignore]
custom_components/satcom_forecast/config_flow.py:212: error: Untyped decorator makes function "async_get_options_flow" untyped  [untyped-decorator]
custom_components/satcom_forecast/config_flow.py:212: note: Error code "untyped-decorator" not covered by "type: ignore" comment

Fix: Add missing type annotations and fix type errors. Common fixes:

• Add return type annotations: def function() -> ReturnType:
• Add parameter type hints: def function(param: ParamType):
• Import needed types: from typing import List, Dict, Optional

✅ Bandit (Security) - PASSED

🚨 Action Required

Some linting checks failed. Please fix the issues above and push your changes.

Quick Fix Commands:

# Auto-fix formatting and imports
black custom_components/satcom_forecast/ tests/
isort --profile=black custom_components/satcom_forecast/ tests/

# Check for remaining issues
flake8 custom_components/satcom_forecast/ tests/ --max-line-length=88 --extend-ignore=E203,W503

---

This comment was automatically generated by GitHub Actions. Check the Actions tab for detailed logs.