Addressing issue #52 "ALL conditional helpers can be inline"#56
Open
tonicblue wants to merge 4 commits intoclay:masterfrom
Open
Addressing issue #52 "ALL conditional helpers can be inline"#56tonicblue wants to merge 4 commits intoclay:masterfrom
tonicblue wants to merge 4 commits intoclay:masterfrom
Conversation
Contributor
|
Hey @tonicblue , sorry for the slow response. We'll look into getting this merged once we identify why Travis didn't build properly. Sorry for the slow response! |
Author
|
That's cool. Sorry I'm now slow to respond too! If it's a quick and easy to describe build issue that I can address just let me know and I'll give it a shot. Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated by @amycheng in issue "ALL conditional helpers can be inline #52",
compareandmodulocan both be used inline. It would be super useful to allowifAll,ifNone,ifAny, andunlessAllto work in the same way.Tried to keep things as simple as possible and copied the way you've written unit tests for everything so there is still the same coverage. I am now however returning
falseinstead of an empty string. Am happy to continue to return an empty string if you'd prefer. Also, likemodulobut unlike an inlineifyou cannot provide anelse="stuff".Hope this is all acceptable,
Cheers for the module