Fix: avoid saving [object Object] in redis#28
Open
pedro-rosario wants to merge 3 commits intoclay:masterfrom
pedro-rosario:redis-put
Open
Fix: avoid saving [object Object] in redis#28pedro-rosario wants to merge 3 commits intoclay:masterfrom pedro-rosario:redis-put
pedro-rosario wants to merge 3 commits intoclay:masterfrom
pedro-rosario:redis-put
Conversation
manuelurenah
approved these changes
Nov 27, 2018
yuliyv
suggested changes
Nov 30, 2018
redis/index.js
Outdated
| if (!shouldProcess(key)) return bluebird.resolve(); | ||
|
|
||
| return module.exports.client.hsetAsync(REDIS_HASH, key, value); | ||
| return module.exports.client.hsetAsync(REDIS_HASH, key, formatValue(value)); |
There was a problem hiding this comment.
Given that this formatting is unexpected behavior (not all PUT requests to this module have required this behavior) I think we should restructure this so we can emit a warn log that we are re-encoding the object before placing it into Redis. So that we can track and squash those issues - we need to be able to log both key and value
yuliyv
approved these changes
May 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to save an object to redis, if its not stringified, we get the following error: