fix: archived tasks view crashes with infinite loop white screen#37
Merged
fix: archived tasks view crashes with infinite loop white screen#37
Conversation
Move .filter() out of Zustand selector into useMemo to prevent getSnapshot returning a new array reference on every call, which caused useSyncExternalStore to loop infinitely.
|
Hi @samzong, DetailsInstructions for interacting with me using comments are available here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getSnapshot should be cachedandMaximum update depth exceedederrorsArchivedTaskscalled.filter()inline, creating a new array reference on every snapshot check → infinite re-render loop.filter()from selector touseMemo, selector now returns the stables.tasksreferenceChanges
packages/desktop/src/renderer/layouts/MainArea/index.tsxuseMemofrom ReactuseTaskStore((s) => s.tasks)(stable reference)useMemo(() => tasks.filter(...), [tasks])(recomputes only when tasks change)Consistent with the existing pattern in
LeftNav(line 77-79).