feat: add keyboard shortcuts with platform-aware modifier keys#36
Merged
feat: add keyboard shortcuts with platform-aware modifier keys#36
Conversation
- Cmd/Ctrl+Shift+O: create new task - Cmd/Ctrl+Shift+F: switch to file browser - Cmd/Ctrl+K: focus search box - Send shortcut toggle (Enter / Cmd+Enter) persisted to AppConfig - Fix: use e.code instead of e.key for reliable macOS shortcut detection - Fix: platform-aware modifier symbol (⌘ on macOS, Ctrl elsewhere) - Fix: startup hydration no longer triggers redundant disk write - Fix: Settings shortcut toggle guards against no-op clicks
|
Hi @samzong, DetailsInstructions for interacting with me using comments are available here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd/Ctrl+Shift+O(new task),Cmd/Ctrl+Shift+F(file browser),Cmd/Ctrl+K(focus search)e.keytoe.codefor reliable modifier+key combos⌘on macOS,Ctrlon Windows/Linux (Settings UI + ChatInput hint)Bug Fixes
e.keyproduces unreliable values whenCmd+Shiftis held;e.codeuses physical key identitysendShortcutfrom config no longer triggersupdateSettings()back to diskChanged Files
App.tsxe.code), hydrate sendShortcut viasetState()ChatInput.tsxSettings/index.tsxmodKeyinterpolationuiStore.tsSendShortcuttype,setSendShortcut,searchFocusTrigger/focusSearchLeftNav/index.tsxsearchInputRef+searchFocusTriggereffectutils.tsisMac,modKeyconstantsconfig.ts,clawwork.d.tssendShortcutfield inAppConfig/AppSettingsen.json,zh.json{{mod}}interpolationVerification
tsc --noEmitpasses with zero errors.