Additional changes to Pytest-based tests and CI workflow #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into additionalchanges
Member
|
It looks like the shallow water on the sphere test failed (core dump). Does it pass for you locally, @carlosmunozmoncayo ? |
Contributor
Author
|
@ketch yes, it passes locally for me. I think this is related to the issue noted by @rjleveque here, but I am not sure what is causing it. The only test expected to fail right now is |
Member
|
With this PR all test pass on my machine too (before this PR, I get an import error for the 3D Euler test). So I'm going to merge this since it's a step forward. But we should figure out what is going on with the shallow water on the sphere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some small changes missing from #721 and a simple GitHub CI workflow for testing.