Topotools - add arguments buffer and align to crop and read_netcdf functions #683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Need to add better doc string to
read_netcdf.In both
cropandread_netcdffunctions, I have added argumentsbufferandalign.bufferinsures that the new topo returned extends beyond the region/extent requested by this many cells (if possible). The defaultbuffer = 0gives the previous behavior, but if the regions specified agrees with the computational domain you plan to use it with, sometimes the topofile thus obtained doesn't quite cover the domain. Settingbuffer = 1may be better.align = (xalign, yalign)is used only ifcoarsen > 1and subsampling is being done.This parameter may be useful to insure that the subsampling starts at an appropriate index. For example, if the original topo has
then coarsening by 2 would result in
or
Often in GeoClaw, if the original topofile is aligned with integer longitudes and latitudes, for example, then we want any subsampled topo to have the same property.