Skip to content

Conversation

@rjleveque
Copy link
Member

require minimal overlap as random small number to avoid rounding error problems when region edge coincides with cell edge, causing tests to fail.

require minimal overlap as random small number to avoid rounding error
problems when region edge coincides with cell edge, causing tests to fail.
@rjleveque
Copy link
Member Author

I think I made the corresponding changes to how Ruled Rectangle flagregions are handled so that determining if there is overlap of a flagregion and a grid cell will not be sensitive to roundoff error.

@mandli
Copy link
Member

mandli commented May 27, 2025

I will try and test this on the new tests and some of the examples and see if I noticed any differences.

@mandli
Copy link
Member

mandli commented May 30, 2025

I ran this through a bunch of storm surge examples that used ruled rectangles and it worked for all of them so I think we are good.

@rjleveque
Copy link
Member Author

Thanks @mandli. I've also done more tests and think this is ok to merge. @mjberger and I have been investigating some strange clustering/gridding that showed up in one of the tests, but that's mostly unrelated to this fix, so I will go ahead and merge.

@rjleveque rjleveque merged commit 9b76d21 into clawpack:master May 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants